mehakmeet commented on a change in pull request #2706: URL: https://github.com/apache/hadoop/pull/2706#discussion_r672037371
########## File path: hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3ABlockOutputStream.java ########## @@ -389,8 +397,10 @@ public void close() throws IOException { // PUT the final block if (hasBlock && (block.hasData() || multiPartUpload.getPartsSubmitted() == 0)) { - //send last part - uploadCurrentBlock(); + // send last part and set the value of isLastPart to true in case of + // CSE being enabled, since we are sure it is last part as parts + // are being uploaded serially in CSE. + uploadCurrentBlock(isCSEEnabled); Review comment: I was thinking about this myself but thought shouldn't we keep the non-CSE behavior as it was, that is pre this patch, we weren't setting the lastPart=true for non-CSE multi-part uploads, and what would be the implications with multiple active blocks as well? But it does make sense to have it true since it would always be the last part uploaded... @steveloughran thoughts?? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org