prasad-acit commented on pull request #3205:
URL: https://github.com/apache/hadoop/pull/3205#issuecomment-885185163
Thanks @shvachko for review and feedback.
> General suggestion here.
>
> 1. Seems there is a fair amount of refactoring going on in the patch, like
adding `createMissingDirs()`. We can do such refactoring on trunk, and then
this change will be smaller, which will make fgl branch maintenance simpler.
-- I got your point. I tried to accommodate these changes into Trunk, but
the changes are more specific to FGL. Also, tried to avoid the refractor, but
it lead to some duplicate code. We don't deviate much from the framework code.
Try to keep the changes minimal.
> 2. It would be good to have a test one can run to verify the change works.
Not necessarily a new test. Could be an existing one.
-- Yes, we do test with existing UTs. Basic functionalities - Create/Delete
File/Dir are fine with FGL. There are other test failures, which we are working
on.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
