9uapaw commented on pull request #3225: URL: https://github.com/apache/hadoop/pull/3225#issuecomment-885565454
Thank you for the patch @bteke. This is a subtle issue, good finding! One note: Is there any drawbacks of not using cloned configuration objects? I can see that the initializeLeafQueueConfigs also clones the config object, and so does the getLeafQueueConfigs (which is doubly meaningless, as it is creating a new Configuration object which is passed to a new CSConfiguration object immediately). I would argue that in order to eliminate the root cause of this issue is to remove these clonings, if they are not essential. As of now, I do not see any advantages of this behaviour over simply populating the csContext config with the templates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
