prasad-acit commented on a change in pull request #3232:
URL: https://github.com/apache/hadoop/pull/3232#discussion_r676183032
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestFileCreation.java
##########
@@ -1313,6 +1313,10 @@ public void testFileIdMismatch() throws IOException {
fail();
} catch(FileNotFoundException e) {
FileSystem.LOG.info("Caught Expected FileNotFoundException: ", e);
+ } catch (AssertionError ae) {
Review comment:
Handling AssertionError is not a good idea. But, this is -ve test case,
if we dont handle Error here then we need to remove the assertion statement in
code.
If any alternative approach, we shall discuss and proceed.
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSDirMkdirOp.java
##########
@@ -284,8 +294,8 @@ private static INode createDirectoryINode(FSDirectory fsd,
byte[] component = iip.getPathComponent(i);
missing[i - existing.length()] =
createDirectoryINode(fsd, existing, component, perm);
- missing[i - existing.length()].setParent(parent.asDirectory());
- parent = missing[i - existing.length()];
+// missing[i - existing.length()].setParent(parent.asDirectory());
Review comment:
This relationship is being set on later stage -addSingleDirectory. This
check lead to some permission related UT failures.
@shvachko , I need your help to have a check. I just commented it out for
reference, if obsolete we shall remove it on later commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
