steveloughran commented on a change in pull request #3239:
URL: https://github.com/apache/hadoop/pull/3239#discussion_r677667371



##########
File path: 
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -539,6 +539,9 @@ public void initialize(URI name, Configuration originalConf)
       if (hasMetadataStore()) {
         LOG.debug("Using metadata store {}, authoritative store={}, 
authoritative path={}",
             getMetadataStore(), allowAuthoritativeMetadataStore, 
allowAuthoritativePaths);
+        if (isCSEEnabled) {

Review comment:
       Initialize is allowed to throw an IOE; our code tends to expect it.
   
   Can you throw a PathIOE(uri, "S3-CSE cannot be used with S3Guard")
   
   i.e give bucket and problem, but don't propose a solution...leave that to 
the docs as disabling s3guard is probably the better one, depending on what the 
user wants




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to