[
https://issues.apache.org/jira/browse/HADOOP-17823?focusedWorklogId=633563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-633563
]
ASF GitHub Bot logged work on HADOOP-17823:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Aug/21 14:04
Start Date: 04/Aug/21 14:04
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3263:
URL: https://github.com/apache/hadoop/pull/3263#discussion_r682647178
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/AbstractS3AMockTest.java
##########
@@ -58,7 +60,12 @@ public void setup() throws Exception {
Configuration conf = createConfiguration();
fs = new S3AFileSystem();
URI uri = URI.create(FS_S3A + "://" + BUCKET);
- fs.initialize(uri, conf);
+ try {
Review comment:
as this is a mock test, best to just remove the s3guard and cse settings
from the config we've created. No real FS should be involved.
We already set metastore to null in `createConfiguration()`.
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/contract/s3a/S3AContract.java
##########
@@ -63,6 +68,22 @@ public S3AContract(Configuration conf, boolean
addContractResource) {
}
}
+ /**
+ * Skip S3AFS initialization if S3-CSE and S3Guard are enabled.
+ *
+ * @throws IOException throw IOE if it is not due to S3-CSE and S3Guard
Review comment:
doesn't any more; will throw `AssumptionViolatedException`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 633563)
Time Spent: 50m (was: 40m)
> S3A Tests to skip if S3Guard and S3-CSE are enabled.
> ----------------------------------------------------
>
> Key: HADOOP-17823
> URL: https://issues.apache.org/jira/browse/HADOOP-17823
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Mehakmeet Singh
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Skip S3A tests when S3Guard and S3-CSE are enabled since it causes PathIOE
> otherwise.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]