Randgalt commented on a change in pull request #3266:
URL: https://github.com/apache/hadoop/pull/3266#discussion_r683403623
##########
File path:
hadoop-common-project/hadoop-registry/src/main/java/org/apache/hadoop/registry/client/impl/zk/CuratorService.java
##########
@@ -824,73 +825,65 @@ protected String dumpRegistryRobustly(boolean verbose) {
*
* @param listener the listener.
* @return a handle allowing for the management of the listener.
- * @throws Exception if registration fails due to error.
*/
- public ListenerHandle registerPathListener(final PathListener listener)
- throws Exception {
-
- final TreeCacheListener pathChildrenCacheListener =
- new TreeCacheListener() {
-
- public void childEvent(CuratorFramework curatorFramework,
- TreeCacheEvent event)
- throws Exception {
- String path = null;
- if (event != null && event.getData() != null) {
- path = event.getData().getPath();
- }
- assert event != null;
- switch (event.getType()) {
- case NODE_ADDED:
- LOG.info("Informing listener of added node {}", path);
- listener.nodeAdded(path);
-
- break;
-
- case NODE_REMOVED:
- LOG.info("Informing listener of removed node {}", path);
- listener.nodeRemoved(path);
-
- break;
-
- case NODE_UPDATED:
- LOG.info("Informing listener of updated node {}", path);
- listener.nodeAdded(path);
-
- break;
-
- default:
- // do nothing
- break;
-
- }
+ public ListenerHandle registerPathListener(final PathListener listener) {
+
+ CuratorCacheListener cacheListener = CuratorCacheListener.builder()
+ .forCreates(childData -> {
Review comment:
Note: there is a `forCreatesAndChanges()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
