mehakmeet commented on a change in pull request #3260:
URL: https://github.com/apache/hadoop/pull/3260#discussion_r684046420
##########
File path:
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java
##########
@@ -822,10 +854,21 @@ private void bindAWSClient(URI name, boolean dtEnabled)
throws IOException {
S3_CLIENT_FACTORY_IMPL, DEFAULT_S3_CLIENT_FACTORY_IMPL,
S3ClientFactory.class);
+ // If there's no endpoint set, then use the default for bucket or
AccessPoint. Overriding is
+ // useful when using FIPS or DualStack S3 endpoints.
+ String endpoint = conf.getTrimmed(ENDPOINT, "");
+ if (endpoint.isEmpty()) {
Review comment:
did you meant to check for `!endpoint.isEmpty()`?
##########
File path:
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/AbstractS3ACostTest.java
##########
@@ -125,6 +126,13 @@ public AbstractS3ACostTest(
public Configuration createConfiguration() {
Configuration conf = super.createConfiguration();
String bucketName = getTestBucketName(conf);
+ // If AccessPoint ARN is set guarded tests are skipped
+ String apArn = conf.get(ACCESS_POINT_ARN, "");
+ if (isGuarded() && !apArn.isEmpty()) {
+ LOG.warn("Skipping test since AccessPoint ARN is set and is incompatible
with S3Guard.");
+ Assume.assumeFalse(true);
Review comment:
+1, also better to use `ContractUtils.skip(SKIP_MESSAGE)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
