virajjasani commented on pull request #3280: URL: https://github.com/apache/hadoop/pull/3280#issuecomment-897418170
Thanks @ferhui for the review. > This PR tile is different from HDFS-12188 Updated Jira title because testDecommissionStatus test is present in both `TestDecommissioningStatus` and `TestDecommissioningStatusWithBackoffMonitor`, hence by just mentioning testDecommissionStatus, we are taking care of both tests failures. > Do you explain why test is flaky and how you fix it? The no of under-replicated blocks on Datanode2 can either be 3 or 4 depending on actual blocks available in Datanode Storage. This is the only reason behind flakiness, hence our logic should be check for count being 3/4. If under replicated blocks are anything other than 3 or 4, then this test has some other genuine failure case. > I see you add synchronized to some functions, Does it help to fix flaky problems? Good point, it doesn't solve flaky problem as of now. I just kept it while running 2 tests in parallel so that config setup is synchronized but now it is not required. I will remove it. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
