sunchao commented on a change in pull request #3250:
URL: https://github.com/apache/hadoop/pull/3250#discussion_r688770891
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/io/compress/TestCodec.java
##########
@@ -882,26 +908,28 @@ private void testGzipCodecWrite(boolean useNative) throws
IOException {
BufferedWriter w = null;
Compressor gzipCompressor = CodecPool.getCompressor(codec);
- if (null != gzipCompressor) {
- // If it gives us back a Compressor, we should be able to use this
- // to write files we can then read back with Java's gzip tools.
- OutputStream os = new CompressorStream(new FileOutputStream(fileName),
- gzipCompressor);
- w = new BufferedWriter(new OutputStreamWriter(os));
- w.write(msg);
- w.close();
- CodecPool.returnCompressor(gzipCompressor);
-
- verifyGzipFile(fileName, msg);
- }
-
- // Create a gzip text file via codec.getOutputStream().
Review comment:
oh I mean the original test with comment "// Create a gzip text file via
codec.getOutputStream()." I think we should change it to use multi-write too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
