[
https://issues.apache.org/jira/browse/HADOOP-7777?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153547#comment-13153547
]
Hadoop QA commented on HADOOP-7777:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12504251/HADOOP-7777-switch.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 10 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 15 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
-1 findbugs. The patch appears to introduce 7 new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/387//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/387//artifact/trunk/hadoop-common-project/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/387//console
This message is automatically generated.
> Implement a base class for DNSToSwitchMapping implementations that can offer
> extra topology information
> -------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-7777
> URL: https://issues.apache.org/jira/browse/HADOOP-7777
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Steve Loughran
> Assignee: Steve Loughran
> Attachments: HADOOP-7777-switch.patch, HADOOP-7777-switch.patch,
> HADOOP-7777-switch.patch, HADOOP-7777-switch.patch, HADOOP-7777-switch.patch
>
>
> HDFS-2492 has identified a need for DNSToSwitchMapping implementations to
> provide a bit more topology information (e.g. whether or not there are
> multiple switches). This could be done by writing an extended interface,
> querying its methods if present and coming up with a default action if there
> is no extended interface.
> Alternatively, we have a base class that all the standard mappings implement,
> with a boolean isMultiRack() method; all the standard subclasses would extend
> this, as could any third party topology provider. The advantage of this
> approach is that it is easier to add new operations without going into a
> multi-interface mess.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
