PrabhuJoseph commented on pull request #3318: URL: https://github.com/apache/hadoop/pull/3318#issuecomment-903449017
Thanks @swathic95 for the patch. 1. Can we add a testcase in TestEntityGroupFSTimelineStore to test the EntityGroupFSTimelineStore#scanForLogs with entity files having Null Owner. Mockito can be added to return Null owner. FileStatus fileStat = mock(FileStatus.class); when(fileStat.gerOwner()).thenReturn(null); 2. And also fix the checkstyle and whitespace issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
