szilard-nemeth commented on a change in pull request #3279:
URL: https://github.com/apache/hadoop/pull/3279#discussion_r694813442
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md
##########
@@ -744,6 +744,14 @@ Changing queue/scheduler properties and adding/removing
queues can be done in tw
Remove the queue configurations from the file and run refresh as described
above
+### Enabling periodic configuration refresh
+Enabling queue configuration periodic refresh allows changing the
configuration by editing the *conf/capacity-scheduler.xml* without the
necessicity of calling yarn rmadmin -refreshQueues.
Review comment:
```suggestion
Enabling queue configuration periodic refresh allows reloading and applying
the configuration by editing the *conf/capacity-scheduler.xml* without the
necessicity of calling yarn rmadmin -refreshQueues.
```
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md
##########
@@ -744,6 +744,14 @@ Changing queue/scheduler properties and adding/removing
queues can be done in tw
Remove the queue configurations from the file and run refresh as described
above
+### Enabling periodic configuration refresh
+Enabling queue configuration periodic refresh allows changing the
configuration by editing the *conf/capacity-scheduler.xml* without the
necessicity of calling yarn rmadmin -refreshQueues.
+
+| Property | Description |
+|:---- |:---- |
+| `yarn.resourcemanager.scheduler.monitor.enable` | Enabling monitoring is
necessary for the periodic refresh. Default value is false. |
+| `yarn.resourcemanager.scheduler.monitor.policies` | You should add
`org.apache.hadoop.yarn.server.resourcemanager.capacity.QueueConfigurationAutoRefreshPolicy`
to the policies list. Default value is
`org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.ProportionalCapacityPreemptionPolicy`.
|
+| `yarn.resourcemanager.queue.auto.refresh.monitoring-interval` | You can
adjust the interval for auto refreshing. Default value is 5000(5s). |
Review comment:
```suggestion
| `yarn.resourcemanager.queue.auto.refresh.monitoring-interval` | Adjusting
the auto-refreshing monitoring interval is possible with this configuration
property. The value is in milliseconds. The default value is 5000 (5 seconds). |
```
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-site/src/site/markdown/CapacityScheduler.md
##########
@@ -744,6 +744,14 @@ Changing queue/scheduler properties and adding/removing
queues can be done in tw
Remove the queue configurations from the file and run refresh as described
above
+### Enabling periodic configuration refresh
+Enabling queue configuration periodic refresh allows changing the
configuration by editing the *conf/capacity-scheduler.xml* without the
necessicity of calling yarn rmadmin -refreshQueues.
+
+| Property | Description |
+|:---- |:---- |
+| `yarn.resourcemanager.scheduler.monitor.enable` | Enabling monitoring is
necessary for the periodic refresh. Default value is false. |
+| `yarn.resourcemanager.scheduler.monitor.policies` | You should add
`org.apache.hadoop.yarn.server.resourcemanager.capacity.QueueConfigurationAutoRefreshPolicy`
to the policies list. Default value is
`org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.ProportionalCapacityPreemptionPolicy`.
|
Review comment:
Please do not use "you should..." here, as @bteke suggested, please use
gerunds.
Also, can you describe in a short sentence what's the difference between
ProportionalCapacityPreemptionPolicy vs. QueueConfigurationAutoRefreshPolicy
and why the user should use the latter?
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
