steveloughran commented on pull request #3312: URL: https://github.com/apache/hadoop/pull/3312#issuecomment-906302865
not compiling I'm afraid. other than that though, looks good we need a test to verify that directory markers still are tagged as this. Rather than add a new test, just patch `ITestXAttrCost` to set the content encoding before the dir. Actually, looking at that existing test suite, I think you could tune those tests to check the content option too. The current tests look for the default content encoding...if in the test setup you set it to gzip, all the probes in that test could be changed to look for it and they would then be validating your code. And then, your new suite only needs to cover new behaviours, like rename. (Yes, I know, mixing things is a key forbidden aspect of JUnit tests, but I'm looking at saving $ as well as execution time.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
