bbeaudreault commented on a change in pull request #3271:
URL: https://github.com/apache/hadoop/pull/3271#discussion_r696619390
##########
File path: hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
##########
@@ -4440,8 +4440,29 @@
<value>3000</value>
<description>
Base time window in ms for DFSClient retries. For each retry attempt,
- this value is extended linearly (e.g. 3000 ms for first attempt and
- first retry, 6000 ms for second retry, 9000 ms for third retry, etc.).
+ this value is extended exponentially based on
dfs.client.retry.window.multiplier.
+ </description>
+</property>
+
+<property>
+ <name>dfs.client.retry.window.multiplier</name>
+ <value>1</value>
+ <description>
+ Multiplier for extending the retry time window. For each retry attempt,
+ the retry time window is extended by multiplying
dfs.client.retry.window.base
+ by this multiplier raised to the power of the current failure count. The
default
+ value of 1 means the window will expand linearly (e.g. 3000 ms for first
attempt
+ and first retry, 6000 ms for second retry, 9000 ms for third retry, etc.).
+ </description>
+</property>
+
+<property>
+ <name>dfs.client.retry.window.max</name>
+ <value>2147483647</value>
Review comment:
@Hexiaoqiao I've pushed a commit which lowers the window max to 30s. As
mentioned above, this may cap some custom backoffs people have configured. But
that may be beneficial. It should not affect the default case, given the
default of 3 retries does not reach 30s. Let me know if you'd prefer a
different default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
