wzhallright commented on a change in pull request #3328:
URL: https://github.com/apache/hadoop/pull/3328#discussion_r696637202
##########
File path:
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java
##########
@@ -517,7 +517,6 @@ private Object invokeMethod(
// Communication retries are handled by the retry policy
if (this.rpcMonitor != null) {
this.rpcMonitor.proxyOpFailureCommunicate();
- this.rpcMonitor.proxyOpComplete(false);
Review comment:
sorry, I didn't understand what you mean.
In my thought, if catch the exception, at least will be +1 by
proxyOpFailureCommunicate.
If namenodes is null, will throw exception.
so maybe proxyOpComplete(false) doesn't make sense.
Or I got it wrong, please correct me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
