Neilxzn commented on pull request #3320: URL: https://github.com/apache/hadoop/pull/3320#issuecomment-906450340
> @Neilxzn Please fix checkstyle and check failed unit tests first. Thanks @Hexiaoqiao Thank you for your review. 1. About BlockPlacementPolicyDefault$chooseTarget, ParameterNumber checkstyle warning is not generated by this patch and it is hard to fix. Maybe we ignore it this patch? 2. I checked these failed tests agian and these tests run pass locally. And these tests seem unrelated. Please review these tests again. Thanks. > hadoop.hdfs.server.namenode.ha.TestEditLogTailer > hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped > hadoop.hdfs.TestHDFSFileSystemContract -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
