[
https://issues.apache.org/jira/browse/HADOOP-17873?focusedWorklogId=642502&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-642502
]
ASF GitHub Bot logged work on HADOOP-17873:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Aug/21 18:10
Start Date: 26/Aug/21 18:10
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3341:
URL: https://github.com/apache/hadoop/pull/3341#discussion_r696867103
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -506,6 +506,9 @@
<include>**/azurebfs/Test*.java</include>
<include>**/azurebfs/**/Test*.java</include>
</includes>
+ <excludes>
Review comment:
even in parallel runs, > only one test case is run in a process at the
same time.
if there's a problem here, it is that the stats need resetting before the run
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsRestOperationException.java
##########
@@ -120,9 +123,9 @@ public void testWithDifferentCustomTokenFetchRetry(int
numOfRetries) throws Exce
// Number of retries done should be as configured
Assert.assertTrue(
- "Number of token fetch retries (" + RetryTestTokenProvider.reTryCount
+ "Number of token fetch retries (" +
retryTestTokenProvider.getReTryCount()
Review comment:
make and assertJ assert .isEqual to help generate the message
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/oauth2/RetryTestTokenProvider.java
##########
@@ -30,20 +30,20 @@
*/
public class RetryTestTokenProvider implements CustomTokenProviderAdaptee {
- // Need to track first token fetch otherwise will get counted as a retry too.
- private static boolean isThisFirstTokenFetch = true;
- public static int reTryCount = 0;
+ private static final Logger LOG = LoggerFactory.getLogger(
+ RetryTestTokenProvider.class);
- private static final Logger LOG = LoggerFactory
- .getLogger(RetryTestTokenProvider.class);
+ // Need to track first token fetch otherwise will get counted as a retry too.
+ private boolean isThisFirstTokenFetch = true;
+ private int reTryCount = 0;
Review comment:
`retryCount`
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/oauth2/RetryTestTokenProvider.java
##########
@@ -30,20 +30,20 @@
*/
public class RetryTestTokenProvider implements CustomTokenProviderAdaptee {
- // Need to track first token fetch otherwise will get counted as a retry too.
- private static boolean isThisFirstTokenFetch = true;
- public static int reTryCount = 0;
+ private static final Logger LOG = LoggerFactory.getLogger(
+ RetryTestTokenProvider.class);
- private static final Logger LOG = LoggerFactory
- .getLogger(RetryTestTokenProvider.class);
+ // Need to track first token fetch otherwise will get counted as a retry too.
+ private boolean isThisFirstTokenFetch = true;
+ private int reTryCount = 0;
@Override
public void initialize(Configuration configuration, String accountName)
throws IOException {
}
- public static void ResetStatusToFirstTokenFetch() {
+ public void resetStatusToFirstTokenFetch() {
Review comment:
add a javadoc of what and why
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 642502)
Time Spent: 1h (was: 50m)
> ABFS: Fix transient failures in ITestAbfsStreamStatistics and
> ITestAbfsRestOperationException
> ---------------------------------------------------------------------------------------------
>
> Key: HADOOP-17873
> URL: https://issues.apache.org/jira/browse/HADOOP-17873
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.1
> Reporter: Sumangala Patki
> Assignee: Sumangala Patki
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> To address transient failures in the following test classes:
> * ITestAbfsStreamStatistics: Uses a filesystem level instance to record
> read/write statistics, which also tracks these operations in other tests.
> running parallelly. To be marked for sequential run only to avoid transient
> failure
> * ITestAbfsRestOperationException: The use of a static member to track retry
> count causes transient failures when two tests of this class happen to run
> together. Switch to non-static variable for assertions on retry count
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
