steveloughran commented on a change in pull request #3332:
URL: https://github.com/apache/hadoop/pull/3332#discussion_r696870198
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TextFileBasedIdentityHandler.java
##########
@@ -172,9 +172,7 @@ private static void loadMap(HashMap<String, String> cache,
String fileLocation,
LOG.debug("Loading identity map from file {}", fileLocation);
int errorRecord = 0;
File file = new File(fileLocation);
- LineIterator it = null;
- try {
- it = FileUtils.lineIterator(file, "UTF-8");
+ try (LineIterator it = FileUtils.lineIterator(file, "UTF-8")) {
Review comment:
we're not going to close quietly any more...can anyone see an issue
that? Given it's a local file read, I don' t personally think it is important
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
