steveloughran commented on pull request #3337: URL: https://github.com/apache/hadoop/pull/3337#issuecomment-907775866
LGTM I've actually been thinking about having better thread pooling here with a RejectedExecutionHandler which * increments a statistic * hands on to ThreadPoolExecutor.CallerRunsPolicy So rather than do blocking when the pool is full, fall back to executing in the current thread. Goal: when the pool is full we still get useful work done because the current thread is doing it. I worry about this though when it comes to things like RenameOperation; is the use of CompletableFuture<> creating expectations in the code that the work will actually be done by a separate thread. How about we merge this patch in as this, and then look at that problem in more detail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
