LeonGao91 commented on a change in pull request #3346:
URL: https://github.com/apache/hadoop/pull/3346#discussion_r698915014
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/NNHAServiceTarget.java
##########
@@ -56,9 +56,25 @@
private final String nnId;
private final String nsId;
private final boolean autoFailoverEnabled;
-
+
public NNHAServiceTarget(Configuration conf,
String nsId, String nnId) {
+ this(conf, nsId, nnId, null, null, null);
+ }
+
+ /**
+ * Create a NNHAServiceTarget for a namenode.
+ *
+ * @param conf HDFS configuration.
+ * @param nsId nsId of this nn.
+ * @param nnId nnId of this nn.
+ * @param serviceAddr Provided service address.
+ * @param addr Provided service address.
+ * @param lifelineAddr Provided service address.
+ */
+ public NNHAServiceTarget(Configuration conf,
Review comment:
Yeah this will look cleaner. I will need to remove the final key word
from some vars as the assignment is out of the constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
