[ 
https://issues.apache.org/jira/browse/HADOOP-7788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13154718#comment-13154718
 ] 

Suresh Srinivas commented on HADOOP-7788:
-----------------------------------------

Comments:
# SERVICE_UNHEALTHY_NOT_RESPONDING - do we have SERVICE_HEALTHY_NOT_RESPONDING? 
If not, we should call this SERVICE_NOT_RESPONDING.
# Please add javadoc to HealthMonitor class and annotations
# Should we document what can be done in callback? Can it take a long time etc.?
# In order to keep the interface complete, it may be a good idea to add 
removeCallBack(). I cannot think of a use for this, right now though.
# CHECK_INTERVAL_DEFAULT is 5 seconds - it would be better do this in shorter 
duration. Say 1s?
# With tests added main() method seems unnecessary.

                
> HA: Simple HealthMonitor class to watch an HAService
> ----------------------------------------------------
>
>                 Key: HADOOP-7788
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7788
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ha
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2524.txt
>
>
> This is a utility class which will be part of the FailoverController. The 
> class starts a daemon thread which periodically monitors an HAService, 
> calling its monitorHealth function. It then generates callbacks into another 
> class when the health status changes (eg the RPC fails or the service returns 
> a HealthCheckFailedException)

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to