jianghuazhu commented on a change in pull request #3365:
URL: https://github.com/apache/hadoop/pull/3365#discussion_r701757347



##########
File path: 
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/async/impl/NMClientAsyncImpl.java
##########
@@ -433,7 +433,7 @@ public void getContainerStatusAsync(ContainerId 
containerId, NodeId nodeId) {
   }
 
   protected enum ContainerState {
-    PREP, FAILED, RUNNING, DONE,
+    PREP, FAILED, RUNNING, DONE

Review comment:
       Thanks @ayushtkn  for the comment. I found that in most places in Hadoop 
projects, when enum is defined, the last element usually does not have any 
symbol, so I think the same style needs to be maintained here. This is my idea.
   Welcome to continue to communicate.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to