[
https://issues.apache.org/jira/browse/HADOOP-17804?focusedWorklogId=646732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-646732
]
ASF GitHub Bot logged work on HADOOP-17804:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/21 02:42
Start Date: 06/Sep/21 02:42
Worklog Time Spent: 10m
Work Description: Neilxzn commented on pull request #3369:
URL: https://github.com/apache/hadoop/pull/3369#issuecomment-913296041
LGTM + 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 646732)
Time Spent: 50m (was: 40m)
> Prometheus metrics only include the last set of labels
> ------------------------------------------------------
>
> Key: HADOOP-17804
> URL: https://issues.apache.org/jira/browse/HADOOP-17804
> Project: Hadoop Common
> Issue Type: Bug
> Components: common
> Affects Versions: 3.3.1
> Reporter: Adam Binford
> Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> A prometheus endpoint was added in
> https://issues.apache.org/jira/browse/HADOOP-16398, but the logic that puts
> them into a map based on the "key" incorrectly hides any metrics with the
> same key but different labels. The relevant code is here:
> [https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/PrometheusMetricsSink.java#L55|https://github.com/apache/hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics2/sink/PrometheusMetricsSink.java#L55.]
> The labels/tags need to be taken into account, as different tags mean
> different metrics. For example, I came across this while trying to scrape
> metrics for all the queues in our scheduler. Only the last queue is included
> because all the metrics have the same "key" but a different "queue" label/tag.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
