TaoYang526 commented on a change in pull request #3389:
URL: https://github.com/apache/hadoop/pull/3389#discussion_r703137210
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java
##########
@@ -687,23 +688,32 @@ public float getUserLimit(String queue) {
return orderingPolicy;
}
- public void setUserLimit(String queue, float userLimit) {
+ public void setUserLimit(String queue, float userLimit) {
setFloat(getQueuePrefix(queue) + USER_LIMIT, userLimit);
LOG.debug("here setUserLimit: queuePrefix={}, userLimit={}",
getQueuePrefix(queue), getUserLimit(queue));
}
+ public void setDefaultUserLimit(float defaultUserLimit) {
Review comment:
We should add @VisibleForTesting annotation if the method is only for
testing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
