viirya commented on pull request #3385: URL: https://github.com/apache/hadoop/pull/3385#issuecomment-914786120
> > Perhaps, we need an integration test for both using normal client and shaded client > > Yes we may need to test that too. We can change [this file](https://github.com/apache/hadoop/blob/trunk/dev-support/bin/hadoop.sh#L551) with the Maven profile `-Pnoshade` I can run the added integration test for shaded clients now. For non-shaded, @sunchao do you mean to copy `shadedclient*` in `hadoop.sh` to another test type and build it with `-Pnoshade`? E.g., ```shell add_test_type noshadedclient function noshadedclient_initialize { ... } function noshadedclient_rebuild { ... echo_and_redirect "${logfile}" \ "${MAVEN}" "${MAVEN_ARGS[@]}" verify -fae --batch-mode -am \ "${modules[@]}" \ -Pnoshade \ -Dtest=NoUnitTests -Dmaven.javadoc.skip=true -Dcheckstyle.skip=true -Dspotbugs.skip=true } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
