brumi1024 commented on a change in pull request #3390:
URL: https://github.com/apache/hadoop/pull/3390#discussion_r704404993
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
##########
@@ -621,39 +619,35 @@ protected void
updateConfigurableResourceRequirement(String queuePath,
} else {
validateAbsoluteVsPercentageCapacityConfig(localType);
}
+ }
+ }
- // If min resource for a resource type is greater than its max resource,
- // throw exception to handle such error configs.
- if (!maxResource.equals(Resources.none()) && Resources.greaterThan(
- resourceCalculator, clusterResource, minResource, maxResource)) {
- throw new IllegalArgumentException("Min resource configuration "
- + minResource + " is greater than its max value:" + maxResource
- + " in queue:" + getQueuePath());
- }
+ protected void updateConfigurableResourceRequirement(Resource
clusterResource) {
Review comment:
Nit: I think updateConfigurableResourceLimits/Constraints describe this
method a bit more, I don't see why this is a requirement if it is limiting the
usage.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
