szilard-nemeth commented on a change in pull request #3355:
URL: https://github.com/apache/hadoop/pull/3355#discussion_r704506770
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java
##########
@@ -427,17 +428,25 @@ public void verifyAndCreateRemoteLogDir() {
throw new YarnRuntimeException("Failed to create remoteLogDir ["
+ remoteRootLogDir + "]", e);
}
- } else{
+ } else {
//Check if FS has capability to set/modify permissions
+ Path permissionCheckFile = new Path(qualified,
String.format("%s.permission_check",
+ RandomStringUtils.randomAlphanumeric(8)));
try {
- remoteFS.setPermission(qualified, new FsPermission(TLDIR_PERMISSIONS));
+ remoteFS.createNewFile(permissionCheckFile);
+ remoteFS.setPermission(permissionCheckFile, new
FsPermission(TLDIR_PERMISSIONS));
} catch (UnsupportedOperationException use) {
LOG.info("Unable to set permissions for configured filesystem since"
+ " it does not support this", remoteFS.getScheme());
fsSupportsChmod = false;
} catch (IOException e) {
LOG.warn("Failed to check if FileSystem suppports permissions on "
Review comment:
Just noticed a small typo here in word "suppports"
This is not related to your patch, but could you please create a follow-up
jira to fix it?
You could create one jira for these 2 issues.
Thanks.
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/logaggregation/filecontroller/LogAggregationFileController.java
##########
@@ -427,17 +428,25 @@ public void verifyAndCreateRemoteLogDir() {
throw new YarnRuntimeException("Failed to create remoteLogDir ["
+ remoteRootLogDir + "]", e);
}
- } else{
+ } else {
//Check if FS has capability to set/modify permissions
+ Path permissionCheckFile = new Path(qualified,
String.format("%s.permission_check",
+ RandomStringUtils.randomAlphanumeric(8)));
try {
- remoteFS.setPermission(qualified, new FsPermission(TLDIR_PERMISSIONS));
+ remoteFS.createNewFile(permissionCheckFile);
+ remoteFS.setPermission(permissionCheckFile, new
FsPermission(TLDIR_PERMISSIONS));
} catch (UnsupportedOperationException use) {
LOG.info("Unable to set permissions for configured filesystem since"
Review comment:
Just noticed a small issue with this log string here.
IntelliJ reports a "More arguments provided (1) than placeholders specified
(0) " warning, this will result in a log record that won't include the scheme
argument as there's no placeholder in the string.
This is not related to your patch, but could you please create a follow-up
jira to fix it?
thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
