viirya commented on a change in pull request #3385:
URL: https://github.com/apache/hadoop/pull/3385#discussion_r704669417
##########
File path:
hadoop-client-modules/hadoop-client-check-invariants/src/test/resources/ensure-jars-have-correct-contents.sh
##########
@@ -67,6 +67,8 @@ allowed_expr+="|^krb5_udp-template.conf$"
# Jetty uses this style sheet for directory listings. TODO ensure our
# internal use of jetty disallows directory listings and remove this.
allowed_expr+="|^jetty-dir.css$"
+# Snappy java is native library. We cannot relocate it to under
org/apache/hadoop.
Review comment:
It is possible, yes. I don't have better idea. Actually I remember when
we checked dependencies at the snappy codec PR, hadoop-common already has
transitive dependency on snappy-java before it. So we didn't make it as
`provided` like lz4-java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
