virajjasani commented on a change in pull request #3386:
URL: https://github.com/apache/hadoop/pull/3386#discussion_r704939307
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
##########
@@ -1068,9 +1070,8 @@ static File moveBlockFiles(Block b, ReplicaInfo
replicaInfo, File destdir)
+ srcReplica + " metadata to "
+ dstMeta, e);
}
- if (LOG.isDebugEnabled()) {
- LOG.info("Linked " + srcReplica.getBlockURI() + " to " + dstFile);
- }
+ LOG.info("Linked {} to {} . Dest meta file: {}",
Review comment:
This seems a bug, we are guarding with isDebugEnabled and if DEBUG is
enabled, we are logging at INFO level. Either we can use INFO or DEBUG directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
