[
https://issues.apache.org/jira/browse/HADOOP-17863?focusedWorklogId=648584&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648584
]
ASF GitHub Bot logged work on HADOOP-17863:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 13:11
Start Date: 09/Sep/21 13:11
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3332:
URL: https://github.com/apache/hadoop/pull/3332#discussion_r705316127
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TextFileBasedIdentityHandler.java
##########
@@ -17,6 +17,7 @@
*/
package org.apache.hadoop.fs.azurebfs.utils;
+import org.apache.hadoop.io.IOUtils;
Review comment:
nit: can you move down to the rest of the "real" org.apache.hadoop
imports.
This matters during backporting, as the `org.apache.hadoop.thirdparty.`
prefix gets cut when we go back to unshaded guava. It's becoming a lot harder
to manage these imports now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 648584)
Time Spent: 2h 10m (was: 2h)
> ABFS: Fix compiler deprecation warning in TextFileBasedIdentityHandler
> ----------------------------------------------------------------------
>
> Key: HADOOP-17863
> URL: https://issues.apache.org/jira/browse/HADOOP-17863
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.1
> Reporter: Sumangala Patki
> Assignee: Sumangala Patki
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> TextFileBasedIdentityHandler uses an instance of LineIterator whose
> closeQuietly method has been deprecated, resulting in compiler warnings
> during yetus runs. Fix by leveraging a try-with-resources block to avoid the
> explicit call to closeQuietly by the LineIterator instance.
> hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TextFileBasedIdentityHandler.java:192:18:[deprecation]
> closeQuietly(LineIterator) in LineIterator has been deprecated
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
