[
https://issues.apache.org/jira/browse/HADOOP-17892?focusedWorklogId=648640&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-648640
]
ASF GitHub Bot logged work on HADOOP-17892:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Sep/21 14:45
Start Date: 09/Sep/21 14:45
Worklog Time Spent: 10m
Work Description: ayushtkn commented on pull request #3387:
URL: https://github.com/apache/hadoop/pull/3387#issuecomment-916167736
I am quite convinced with having a formatter checked in to the code.
Mostly, if it can take care of import ordering. With a exception that we
keep the shaded guava imports at the same place as we would have kept, if it
was a normal guava import to keep backporting easy(I was told to do so in one
PR)
I think I missed the thread on common-dev, If others are ok, then it should
be fine.
What is the source of these xmls, you have written them? If yes, we need
someone who can decode this as well, Which I am certainly not :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 648640)
Time Spent: 2h 10m (was: 2h)
> Add Hadoop code formatter in dev-support
> ----------------------------------------
>
> Key: HADOOP-17892
> URL: https://issues.apache.org/jira/browse/HADOOP-17892
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> We should add Hadoop code formatter xml to dev-support specifically for new
> developers to refer to.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
