szilard-nemeth commented on a change in pull request #3360:
URL: https://github.com/apache/hadoop/pull/3360#discussion_r706178106
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueue.java
##########
@@ -1729,7 +1731,8 @@ public void updateLastSubmittedTimeStamp() {
}
}
- public long getLastSubmittedTimestamp() {
+ @VisibleForTesting
+ long getLastSubmittedTimestamp() {
Review comment:
As a second thought: getLastSubmittedTimestamp is called from
org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue#isInactiveDynamicQueue
so technically it could have been private if it wasn't accessed from test code
so I think VisibleForTesting is correct here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
