sunchao commented on a change in pull request #3385:
URL: https://github.com/apache/hadoop/pull/3385#discussion_r706416829
##########
File path: hadoop-client-modules/hadoop-client-runtime/pom.xml
##########
@@ -155,6 +155,8 @@
<exclude>org.ow2.asm:*</exclude>
<!-- Leave bouncycastle unshaded because it's signed
with a special Oracle certificate so it can be a custom JCE security provider
-->
<exclude>org.bouncycastle:*</exclude>
+ <!-- Leave snappy that includes native methods which
cannot be relocated. -->
+ <exclude>org.xerial.snappy:*</exclude>
Review comment:
When I check dependency:tree, snappy is compile scope:
```
[INFO] | +-
org.apache.hadoop:hadoop-mapreduce-client-core:jar:3.4.0-SNAPSHOT:compile
(optional)·
[INFO] | | \-
org.apache.hadoop:hadoop-yarn-common:jar:3.4.0-SNAPSHOT:compile (optional)·
[INFO] | | +- javax.servlet:javax.servlet-api:jar:3.1.0:compile
(optional)·
[INFO] | | +- com.sun.jersey:jersey-core:jar:1.19:compile (optional)·
[INFO] | | | \- javax.ws.rs:jsr311-api:jar:1.1.1:compile (optional)·
[INFO] | | +- com.sun.jersey:jersey-client:jar:1.19:compile (optional)·
[INFO] | | +-
com.fasterxml.jackson.module:jackson-module-jaxb-annotations:jar:2.10.5:compile
(optional)·
[INFO] | | | \-
jakarta.xml.bind:jakarta.xml.bind-api:jar:2.3.2:compile (optional)·
[INFO] | | \-
com.fasterxml.jackson.jaxrs:jackson-jaxrs-json-provider:jar:2.10.5:compile
(optional)·
[INFO] | | \-
com.fasterxml.jackson.jaxrs:jackson-jaxrs-base:jar:2.10.5:compile (optional)·
[INFO] | \-
org.apache.hadoop:hadoop-mapreduce-client-jobclient:jar:3.4.0-SNAPSHOT:compile
(optional)·
[INFO] | \-
org.apache.hadoop:hadoop-mapreduce-client-common:jar:3.4.0-SNAPSHOT:compile
(optional)·
[INFO] +- org.apache.hadoop:hadoop-client-api:jar:3.4.0-SNAPSHOT:runtime
[INFO] | \- org.xerial.snappy:snappy-java:jar:1.1.8.2:compile
[INFO] +- org.apache.hadoop:hadoop-annotations:jar:3.4.0-SNAPSHOT:compile
[INFO] +- org.slf4j:slf4j-api:jar:1.7.30:runtime
[INFO] +- commons-logging:commons-logging:jar:1.1.3:runtime
[INFO] +- com.google.code.findbugs:jsr305:jar:3.0.2:runtime
[INFO] \- log4j:log4j:jar:1.2.17:runtime (optional)·
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
