pbacsko commented on a change in pull request #3423:
URL: https://github.com/apache/hadoop/pull/3423#discussion_r706827825
##########
File path:
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/Text.java
##########
@@ -73,6 +73,10 @@ protected CharsetDecoder initialValue() {
}
};
+ // max size of the byte array, seems to be a safe choice for multiple VMs
Review comment:
Maybe I should have written different kind of VMs (OpenJDK, HotSpot,
etc). It's more like a practical value that will likely work under different
versions. Some details:
https://programming.guide/java/array-maximum-length.html. If this comment is
confusing, I can remove it (or perhaps extend it a little bit?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
