virajjasani commented on a change in pull request #3386:
URL: https://github.com/apache/hadoop/pull/3386#discussion_r707040398
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
##########
@@ -1050,8 +1050,10 @@ static File moveBlockFiles(Block b, ReplicaInfo
replicaInfo, File destdir)
File dstFile)
throws IOException {
// Create parent folder if not exists.
- srcReplica.getFileIoProvider()
+ boolean isDirCreated = srcReplica.getFileIoProvider()
.mkdirs(srcReplica.getVolume(), dstFile.getParentFile());
+ LOG.trace("Dir creation of {} on volume {} {}", dstFile.getParentFile(),
Review comment:
Updated to use already extracted objects so that only if TRACE level is
enabled, those objects' toString() will be extracted. Without TRACE level being
enabled, placeholder object's toString() won't be called so perf penalty (if
applicable) will be only restricted to TRACE level logging. Does this sound
good?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
