ferhui commented on a change in pull request #3366:
URL: https://github.com/apache/hadoop/pull/3366#discussion_r707277187
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
##########
@@ -6537,14 +6537,45 @@ public String getLiveNodes() {
if (node.getUpgradeDomain() != null) {
innerinfo.put("upgradeDomain", node.getUpgradeDomain());
}
+ StorageReport[] storageReports = node.getStorageReports();
+ innerinfo.put("blockPoolUsedPercentStdDev",
+ getBlockPoolUsedPercentStdDev(storageReports));
info.put(node.getXferAddrWithHostname(), innerinfo.build());
}
return JSON.toString(info);
}
+ /**
+ * Return the standard deviation of storage block pool usage.
+ */
+ @VisibleForTesting
+ public float getBlockPoolUsedPercentStdDev(StorageReport[] storageReports) {
+ ArrayList<Float> usagePercentList = new ArrayList<>();
+ float totalUsagePercent = 0.0f;
+ float dev = 0.0f;
+
+ if (storageReports.length == 0) {
+ return dev;
+ }
+
+ for (StorageReport s : storageReports) {
+ usagePercentList.add(s.getBlockPoolUsagePercent());
+ totalUsagePercent += s.getBlockPoolUsagePercent();
+ }
+
+ totalUsagePercent /= storageReports.length;
+ Collections.sort(usagePercentList);
Review comment:
@tomscut _assertEquals(String message, float expected, float actual,
float delta)_ Can you try this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
