wzhallright edited a comment on pull request #3317: URL: https://github.com/apache/hadoop/pull/3317#issuecomment-919656426
> Can you address the checkstyle issue? > > ``` > ./hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/server/JournalMetrics.java:54: MutableStat rpcRequestCacheMissAmount;:15: Variable 'rpcRequestCacheMissAmount' must be private and have accessor methods. [VisibilityModifier] > ``` > > Previously with the `@Metric` annotation it had to be package-private to be accessible to metrics2, but now it's no longer necessary and we can resolve this by making it private. > > LGTM other than that, the only unit test failing is `TestBalancer` which I have seen be flaky in the past and doesn't look related. OK, I have fixed the checkstyle, PTAL,Thanks. @xkrogen -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
