GauthamBanasandra commented on a change in pull request #3349:
URL: https://github.com/apache/hadoop/pull/3349#discussion_r709224778
##########
File path: start-build-env.sh
##########
@@ -1,4 +1,4 @@
-#!/bin/bash
Review comment:
`start-build-env.sh` creates the build environment based on
`Dockerfile`. Since you haven't modified `Dockerfile` in this PR, you shouldn't
change this file as well.
Here's my suggestion to you - let's keep the old way as it is, which is,
building using Virtualbox that uses `Dockerfile`. Those who want to use Docker
for building can use `Dockerfile_centos_7` directly and not through
`start-build-env.sh` -
```shell
$ docker build -t hadoop-centos-7 -f
.\dev-support\docker\Dockerfile_centos_7 .\dev-support\docker\
```
##########
File path: BUILDING.txt
##########
@@ -21,38 +21,15 @@ The easiest way to get an environment with all the
appropriate tools is by means
of the provided Docker config.
This requires a recent version of docker (1.4.1 and higher are known to work).
-On Linux:
+On Linux or Mac:
Install Docker and run this command:
$ ./start-build-env.sh
-On Mac:
- First make sure Virtualbox and docker toolbox are installed.
- You can use docker toolbox as described in
http://docs.docker.com/mac/step_one/.
- $ docker-machine create --driver virtualbox \
- --virtualbox-memory "4096" hadoopdev
- $ eval $(docker-machine env hadoopdev)
- $ ./start-build-env.sh
-
-The prompt which is then presented is located at a mounted version of the
source tree
-and all required tools for testing and building have been installed and
configured.
-
Note that from within this docker environment you ONLY have access to the
Hadoop source
tree from where you started. So if you need to run
dev-support/bin/test-patch /path/to/my.patch
then the patch must be placed inside the hadoop source tree.
-
-Known issues:
-- On Mac with Boot2Docker the performance on the mounted directory is
currently extremely slow.
- This is a known problem related to boot2docker on the Mac.
- See:
- https://github.com/boot2docker/boot2docker/issues/593
- This issue has been resolved as a duplicate, and they point to a new feature
for utilizing NFS mounts
- as the proposed solution:
- https://github.com/boot2docker/boot2docker/issues/64
- An alternative solution to this problem is to install Linux native inside a
virtual machine
- and run your IDE and Docker etc inside that VM.
Review comment:
I think we should retain the ability to build using Virtualbox and your
PR would just add the ability to build using Docker, instead of deprecating the
ability to build using Virtualbox. With that said, you wouldn't need to modify
the docs here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
