[
https://issues.apache.org/jira/browse/HADOOP-17873?focusedWorklogId=651707&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-651707
]
ASF GitHub Bot logged work on HADOOP-17873:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 16/Sep/21 14:06
Start Date: 16/Sep/21 14:06
Worklog Time Spent: 10m
Work Description: sumangala-patki commented on a change in pull request
#3341:
URL: https://github.com/apache/hadoop/pull/3341#discussion_r710153843
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/oauth2/RetryTestTokenProvider.java
##########
@@ -30,30 +30,34 @@
*/
public class RetryTestTokenProvider implements CustomTokenProviderAdaptee {
- // Need to track first token fetch otherwise will get counted as a retry too.
- private static boolean isThisFirstTokenFetch = true;
- public static int reTryCount = 0;
+ private static final Logger LOG = LoggerFactory.getLogger(
+ RetryTestTokenProvider.class);
- private static final Logger LOG = LoggerFactory
- .getLogger(RetryTestTokenProvider.class);
+ // Need to track first token fetch otherwise will get counted as a retry too.
+ private boolean isThisFirstTokenFetch = true;
+ private int retryCount = 0;
@Override
public void initialize(Configuration configuration, String accountName)
throws IOException {
}
- public static void ResetStatusToFirstTokenFetch() {
+ /**
+ * Clear earlier retry details and reset RetryTestTokenProvider instance to
+ * state of first access token fetch call
Review comment:
added
When parallel is set to "classes" (instead of "both"), the StreamStats test
passes even with the failure scenario induced by dummy test, as the two tests
are run sequentially in the process. However, I guess there might be occasional
failures if a different class reads/writes simultaneously in a different
process; could not reproduce failure though.
Have made a minor correction to the pom file; the test will be excluded from
the parallel run (currently classesandMethods/both) and executed separately
along with a bunch of other integration tests that need to be run sequentially
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 651707)
Time Spent: 5h (was: 4h 50m)
> ABFS: Fix transient failures in ITestAbfsStreamStatistics and
> ITestAbfsRestOperationException
> ---------------------------------------------------------------------------------------------
>
> Key: HADOOP-17873
> URL: https://issues.apache.org/jira/browse/HADOOP-17873
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.3.1
> Reporter: Sumangala Patki
> Assignee: Sumangala Patki
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> To address transient failures in the following test classes:
> * ITestAbfsStreamStatistics: Uses a filesystem level instance to record
> read/write statistics, which also tracks these operations in other tests.
> running parallelly. To be marked for sequential run only to avoid transient
> failure
> * ITestAbfsRestOperationException: The use of a static member to track retry
> count causes transient failures when two tests of this class happen to run
> together. Switch to non-static variable for assertions on retry count
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
