ferhui commented on a change in pull request #2918:
URL: https://github.com/apache/hadoop/pull/2918#discussion_r711729721
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/PBImageTextWriter.java
##########
@@ -562,7 +579,9 @@ void append(StringBuffer buffer, String field) {
*/
abstract protected void afterOutput() throws IOException;
- public void visit(RandomAccessFile file) throws IOException {
+ public void visit(String filePath) throws IOException {
+ filename = new File(filePath);
+ RandomAccessFile file = new RandomAccessFile(filePath, "r");
Review comment:
Maybe it is unnecessary to change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
