9uapaw commented on a change in pull request #3430: URL: https://github.com/apache/hadoop/pull/3430#discussion_r710790031
########## File path: hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/AbstractCSQueueUsageTracker.java ########## @@ -0,0 +1,78 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity; + +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.QueueResourceQuotas; +import org.apache.hadoop.yarn.server.resourcemanager.scheduler.ResourceUsage; + +public class AbstractCSQueueUsageTracker { + private final CSQueueMetrics metrics; + private volatile int numContainers; + + /** + * The timestamp of the last submitted application to this queue. + * Only applies to dynamic queues. + */ + private long lastSubmittedTimestamp; + + /** + * Tracks resource usage by label like used-resource / pending-resource. + */ + private volatile ResourceUsage queueUsage; + + private final QueueResourceQuotas queueResourceQuotas; + + public AbstractCSQueueUsageTracker(CSQueueMetrics metrics) { + this.metrics = metrics; + this.queueUsage = new ResourceUsage(); + this.queueResourceQuotas = new QueueResourceQuotas(); + } + + public int getNumContainers() { + return numContainers; + } + + public synchronized void increaseNumContainers() { + numContainers++; + } + + public synchronized void decreaseNumContainers() { Review comment: I think making these methods synchronized is not a good idea. This will make the whole object locked, which is unnecessary, because the queue already has its own fine-grained RWLock, which is used for synchronization. I think an all-in or nothing methodology is better here: either make the whole class thread-safe, or let the queue handle the synchronization. In my opinion, since its only used internally within the queue, the latter would be better. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
