[
https://issues.apache.org/jira/browse/HADOOP-17195?focusedWorklogId=652825&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-652825
]
ASF GitHub Bot logged work on HADOOP-17195:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/21 08:24
Start Date: 20/Sep/21 08:24
Worklog Time Spent: 10m
Work Description: mehakmeet commented on a change in pull request #3446:
URL: https://github.com/apache/hadoop/pull/3446#discussion_r711964317
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/ITestAbfsHugeFiles.java
##########
@@ -0,0 +1,97 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.hadoop.fs.azurebfs;
+
+import java.io.IOException;
+import java.util.Arrays;
+import java.util.Random;
+
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.Parameterized;
+
+import org.apache.hadoop.fs.FSDataOutputStream;
+import org.apache.hadoop.fs.Path;
+
+import static org.apache.hadoop.fs.azure.integration.AzureTestUtils.assume;
+import static
org.apache.hadoop.fs.azurebfs.constants.FileSystemConfigurations.DEFAULT_WRITE_BUFFER_SIZE;
+
+/**
+ * Testing Huge file for AbfsOutputStream.
+ */
+@RunWith(Parameterized.class)
+public class ITestAbfsHugeFiles extends AbstractAbfsScaleTest {
+ private static final int ONE_MB = 1024 * 1024;
+ private static final int EIGHT_MB = 8 * ONE_MB;
+ private final int size;
+
+ @Parameterized.Parameters(name = "Size={0}")
+ public static Iterable<Object[]> sizes() {
+ return Arrays.asList(new Object[][] {
+ { DEFAULT_WRITE_BUFFER_SIZE },
+ { getHugeFileUploadValue() } });
+ }
+
+ public ITestAbfsHugeFiles(int size) throws Exception {
+ this.size = size;
+ }
+
+ /**
+ * Testing Huge files written at once on AbfsOutputStream.
+ */
+ @Test
+ public void testHugeFileWrite() throws IOException {
+ AzureBlobFileSystem fs = getFileSystem();
+ Path filePath = path(getMethodName());
+ final byte[] b = new byte[size];
+ new Random().nextBytes(b);
+ try (FSDataOutputStream out = fs.create(filePath)) {
+ out.write(b);
+ }
+ // Verify correct length was uploaded. Don't want to verify contents
+ // here, as this would increase the test time significantly.
+ assertEquals("Mismatch in content length of file uploaded", size,
Review comment:
Don't think ABFS supports checksums? @steveloughran?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 652825)
Time Spent: 5h (was: 4h 50m)
> Intermittent OutOfMemory error while performing hdfs CopyFromLocal to abfs
> ---------------------------------------------------------------------------
>
> Key: HADOOP-17195
> URL: https://issues.apache.org/jira/browse/HADOOP-17195
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Affects Versions: 3.3.0
> Reporter: Mehakmeet Singh
> Assignee: Mehakmeet Singh
> Priority: Major
> Labels: abfsactive, pull-request-available
> Time Spent: 5h
> Remaining Estimate: 0h
>
> OutOfMemory error due to new ThreadPools being made each time
> AbfsOutputStream is created. Since threadPool aren't limited a lot of data is
> loaded in buffer and thus it causes OutOfMemory error.
> Possible fixes:
> - Limit the number of ThreadCounts while performing hdfs copyFromLocal (Using
> -t property).
> - Reducing OUTPUT_BUFFER_SIZE significantly which would limit the amount of
> buffer to be loaded in threads.
> - Don't create new ThreadPools each time AbfsOutputStream is created and
> limit the number of ThreadPools each AbfsOutputStream could create.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
