mehakmeet commented on a change in pull request #3442:
URL: https://github.com/apache/hadoop/pull/3442#discussion_r712383041
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/extensions/ITestAbfsDelegationTokens.java
##########
@@ -264,15 +286,21 @@ public StubAbfsTokenIdentifier
verifyCredentialsContainsToken(
Token<? extends TokenIdentifier> token = credentials.getToken(
new Text(serviceName));
- assertEquals("Token Kind in " + token,
- StubAbfsTokenIdentifier.TOKEN_KIND, token.getKind());
- assertEquals("Token Service Kind in " + token,
- tokenService, token.getService().toString());
+ Assertions.assertThat(token)
+ .describedAs("No token found for %s", serviceName)
+ .isNotNull();
+
+ Assertions.assertThat(token.getKind())
+ .describedAs("Token Kind in %s", token)
+ .isEqualTo(StubAbfsTokenIdentifier.TOKEN_KIND);
+ Assertions.assertThat(token.getService().toString())
Review comment:
assert for isNotNull for token.getService() before toString()?
##########
File path:
hadoop-tools/hadoop-azure/src/test/java/org/apache/hadoop/fs/azurebfs/extensions/TestDTManagerLifecycle.java
##########
@@ -50,6 +50,12 @@
public static final URI FSURI = newURI(ABFS);
+ public static final String CANONICAL_SERVICE_NAME =
Review comment:
Never used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
