mehakmeet commented on pull request #3462: URL: https://github.com/apache/hadoop/pull/3462#issuecomment-924240282
Thanks for the changes @steveloughran. I did the cherry-pick. One thing to note is that the method used `S3AUtils.getEncryptionAlgortihm()` does its validation as well, so the Strings provided: "new-key-global" and "old-key-bucket", would cause an unknown encryption method exception. So, I just replaced them with "CSE-KMS" and "SSE-KMS". Still the same test just different string value. Coming to the tests. As expected the JCEKS test fails and gives the new global priority over old per-bucket configs. >Then we can get that method to do what we want So, basically, we would now make changes to the way we look-up so that this test passes and per-bucket config old or new gets priority over everything else? Also, nice docs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
