[ 
https://issues.apache.org/jira/browse/HADOOP-17922?focusedWorklogId=653742&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-653742
 ]

ASF GitHub Bot logged work on HADOOP-17922:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Sep/21 18:17
            Start Date: 21/Sep/21 18:17
    Worklog Time Spent: 10m 
      Work Description: mehakmeet commented on pull request #3462:
URL: https://github.com/apache/hadoop/pull/3462#issuecomment-924240282


   Thanks for the changes @steveloughran. 
   I did the cherry-pick. One thing to note is that the method used  
`S3AUtils.getEncryptionAlgortihm()` does its validation as well, so the Strings 
provided: "new-key-global" and "old-key-bucket", would cause an unknown 
encryption method exception. So, I just replaced them with "CSE-KMS" and 
"SSE-KMS". Still the same test just different string value.
   
   Coming to the tests. As expected the JCEKS test fails and gives the new 
global priority over old per-bucket configs.
   >Then we can get that method to do what we want
   
   So, basically, we would now make changes to the way we look-up so that this 
test passes and per-bucket config old or new gets priority over everything else?
   Also, nice docs.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 653742)
    Time Spent: 2h 40m  (was: 2.5h)

> Lookup old S3 encryption configs for JCEKS
> ------------------------------------------
>
>                 Key: HADOOP-17922
>                 URL: https://issues.apache.org/jira/browse/HADOOP-17922
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Mehakmeet Singh
>            Assignee: Mehakmeet Singh
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> HADOOP-17871 introduces new set of S3 encryption configs which are replaced 
> by old property names during look-up. We need to look-up for both the 
> properties since either could be set in a JCEKS file.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to