tomscut commented on a change in pull request #3479:
URL: https://github.com/apache/hadoop/pull/3479#discussion_r716056546
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/BPOfferService.java
##########
@@ -811,9 +811,10 @@ assert getBlockPoolId().equals(bp) :
*/
private boolean processCommandFromStandby(DatanodeCommand cmd,
BPServiceActor actor) throws IOException {
+ String who = ", NameNode at " + actor.getNNSocketAddress();
switch(cmd.getAction()) {
case DatanodeProtocol.DNA_ACCESSKEYUPDATE:
- LOG.info("DatanodeCommand action from standby: DNA_ACCESSKEYUPDATE");
+ LOG.info("DatanodeCommand action from standby: DNA_ACCESSKEYUPDATE" +
who);
Review comment:
It might be better to use a placeholder like:
`LOG.info("DatanodeCommand action from standby NN {}: DNA_ACCESSKEYUPDATE,
actor.getNNSocketAddress());`
Several other places can be used in a similar manner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
