tomicooler commented on a change in pull request #3459:
URL: https://github.com/apache/hadoop/pull/3459#discussion_r716421615
##########
File path:
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/test/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerTestBase.java
##########
@@ -27,37 +27,14 @@
import java.util.Set;
public class CapacitySchedulerTestBase {
- protected final int GB = 1024;
-
- protected static final String A = CapacitySchedulerConfiguration.ROOT + ".a";
- protected static final String B = CapacitySchedulerConfiguration.ROOT + ".b";
- protected static final String A1 = A + ".a1";
- protected static final String A2 = A + ".a2";
- protected static final String B1 = B + ".b1";
- protected static final String B2 = B + ".b2";
- protected static final String B3 = B + ".b3";
- protected static float A_CAPACITY = 10.5f;
- protected static float B_CAPACITY = 89.5f;
- protected static final String P1 = CapacitySchedulerConfiguration.ROOT +
".p1";
- protected static final String P2 = CapacitySchedulerConfiguration.ROOT +
".p2";
- protected static final String X1 = P1 + ".x1";
- protected static final String X2 = P1 + ".x2";
- protected static final String Y1 = P2 + ".y1";
- protected static final String Y2 = P2 + ".y2";
- protected static float A1_CAPACITY = 30;
- protected static float A2_CAPACITY = 70;
- protected static float B1_CAPACITY = 79.2f;
- protected static float B2_CAPACITY = 0.8f;
- protected static float B3_CAPACITY = 20;
-
+ public static final int GB = 1024;
Review comment:
Made it to a utility class: CapacitySchedulerTestUtilities.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
