[
https://issues.apache.org/jira/browse/HADOOP-17934?focusedWorklogId=656294&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-656294
]
ASF GitHub Bot logged work on HADOOP-17934:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Sep/21 17:59
Start Date: 28/Sep/21 17:59
Worklog Time Spent: 10m
Work Description: steveloughran commented on a change in pull request
#3477:
URL: https://github.com/apache/hadoop/pull/3477#discussion_r717834946
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -822,10 +839,11 @@ public AbfsRestOperation deletePath(final String path,
final boolean recursive,
* delete issued from this filesystem instance.
* These are few corner cases and usually returning a success at this stage
* should help the job to continue.
- * @param op Delete request REST operation response
+ * @param op Delete request REST operation response with non-null HTTP
response
* @return REST operation response post idempotency check
*/
public AbfsRestOperation deleteIdempotencyCheckOp(final AbfsRestOperation
op) {
+ assert op.hasResult();
Review comment:
why assert & not Preconditions.checkArgument()? you confident that we
don't normally need this check? or happy with the fact that there'll be an NPE
shortly afterwards anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 656294)
Time Spent: 1h 20m (was: 1h 10m)
> NullPointerException when no HTTP response set on AbfsRestOperation
> -------------------------------------------------------------------
>
> Key: HADOOP-17934
> URL: https://issues.apache.org/jira/browse/HADOOP-17934
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/azure
> Reporter: Josh Elser
> Assignee: Josh Elser
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Seen when running HBase 2.2 on top of ABFS with Hadoop 3.1ish:
> {noformat}
> Caused by: java.lang.NullPointerException
> at
> org.apache.hadoop.fs.azurebfs.services.AbfsClient.renameIdempotencyCheckOp(AbfsClient.java:382)
> at
> org.apache.hadoop.fs.azurebfs.services.AbfsClient.renamePath(AbfsClient.java:348)
> at
> org.apache.hadoop.fs.azurebfs.AzureBlobFileSystemStore.rename(AzureBlobFileSystemStore.java:722)
> at
> org.apache.hadoop.fs.azurebfs.AzureBlobFileSystem.rename(AzureBlobFileSystem.java:327)
> at
> org.apache.hadoop.fs.FilterFileSystem.rename(FilterFileSystem.java:249)
> at
> org.apache.hadoop.hbase.regionserver.HRegionFileSystem.rename(HRegionFileSystem.java:1115)
> {noformat}
> Digging in, it looks like the {{AbfsHttpOperation}} inside of
> {{AbfsRestOperation}} may sometimes be null, but {{AbfsClient}} will try to
> unwrap it (and read the status code from the HTTP call). I'm not sure why we
> sometimes _get_ the null HttpOperation but it seems pretty straightforward to
> not get the NPE.
> HBase got wedged after this, but I'm not sure if it's because of this NPE or
> (perhaps) we weren't getting any responses from ABFS itself (i.e. there was
> some ABFS outage/unavailability or the node itself couldn't talk to ABFS).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
