steveloughran commented on a change in pull request #3477:
URL: https://github.com/apache/hadoop/pull/3477#discussion_r717834946
##########
File path:
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java
##########
@@ -822,10 +839,11 @@ public AbfsRestOperation deletePath(final String path,
final boolean recursive,
* delete issued from this filesystem instance.
* These are few corner cases and usually returning a success at this stage
* should help the job to continue.
- * @param op Delete request REST operation response
+ * @param op Delete request REST operation response with non-null HTTP
response
* @return REST operation response post idempotency check
*/
public AbfsRestOperation deleteIdempotencyCheckOp(final AbfsRestOperation
op) {
+ assert op.hasResult();
Review comment:
why assert & not Preconditions.checkArgument()? you confident that we
don't normally need this check? or happy with the fact that there'll be an NPE
shortly afterwards anyway?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
